My name
is
Jon Skeet

ERROR: The process cannot access the file 'Companion.jpg' because it is being used by another process

I have a problem when trying to delete the files from a directory because it says a file is being used by another process. I cant figure out how to delete all the files in the folder after I run the cmdCombine Method. Here is the code, a little help please:

    private void cmdCombine_Click(object sender, EventArgs e)
    {
        DirectoryInfo directory = new DirectoryInfo(@"C:\Users\Elder Zollinger\Desktop\Images");
        if (directory != null)
        {
            FileInfo[] files = directory.GetFiles();
            ResizeImages(files);

        }
        DirectoryInfo directory2 = new DirectoryInfo(@"C:\Users\Elder Zollinger\Desktop\Upload");
        if (directory2 != null)
        {
            FileInfo[] files = directory2.GetFiles();
            CombineImages(files);
            System.IO.DirectoryInfo downloadedMessageInfo = new DirectoryInfo(@"C:\Users\Elder Zollinger\Desktop\Images");

            foreach (FileInfo file2 in downloadedMessageInfo.GetFiles())
            {
                file2.Delete();
            }
            foreach (DirectoryInfo dir in downloadedMessageInfo.GetDirectories())
            {
                dir.Delete(true);
            }
        }

    }
    //Method for resizing the images
    private void ResizeImages(FileInfo[] files)
    {
        //Set Count integers and strings to save files
        int fileCount = Directory.GetFiles(@"C:\Users\Elder Zollinger\Desktop\Images").Length;
        int count = 1;
        string fileNameOnly = Path.GetFileNameWithoutExtension(@"C:\Users\Elder Zollinger\Desktop\Upload\NewImage.jpg");
        string extension = Path.GetExtension(@"C:\Users\Elder Zollinger\Desktop\Upload\NewImage.jpg");
        string uploadPath = Path.GetDirectoryName(@"C:\Users\Elder Zollinger\Desktop\Upload\NewImage.jpg");
        string newFullUploadPath = @"C:\Users\Elder Zollinger\Desktop\Upload\NewImage.jpg";

        //Read Files in the folder
        foreach (FileInfo file in files)
        {
            //Create a new file name that doesnt exist
            while (File.Exists(newFullUploadPath))
            {
                string tempFileName = string.Format("{0}({1})", fileNameOnly, count++);
                newFullUploadPath = Path.Combine(uploadPath, tempFileName + extension);
            }

            //Resize and save images when there is more than 2
            if (fileCount > 2)
            {
                Image img = Image.FromFile(file.FullName);
                var newImage = resizeImage(img, new Size(66, 200));
                newImage.Save(newFullUploadPath, System.Drawing.Imaging.ImageFormat.Jpeg);
            }

            //Resize and save images for 1 or 2 images
            else
            {
                Image img = Image.FromFile(file.FullName);
                var newImage = resizeImage(img, new Size(100, 200));
                newImage.Save(newFullUploadPath, System.Drawing.Imaging.ImageFormat.Jpeg);
            }
        }
    }

    //Stitch Images
    private void CombineImages(FileInfo[] files)
    {
        //Create strings for saved images
        int count = 1;
        string fileNameOnly = Path.GetFileNameWithoutExtension(@"C:\Users\Elder Zollinger\Desktop\Dump\Final.jpg");
        string extension = Path.GetExtension(@"C:\Users\Elder Zollinger\Desktop\Dump\Final.jpg");
        string uploadPath = Path.GetDirectoryName(@"C:\Users\Elder Zollinger\Desktop\Dump\Final.jpg");
        string newFullUploadPath = @"C:\Users\Elder Zollinger\Desktop\Dump\Final.jpg";
        List<int> imageHeights = new List<int>();
        int nIndex = 0;
        int width = 0;
        foreach (FileInfo file in files)
        {
            Image img = Image.FromFile(file.FullName);
            imageHeights.Add(img.Height);
            width += img.Width;
            img.Dispose();
        }
        imageHeights.Sort();
        int height = imageHeights[imageHeights.Count - 1];
        Bitmap img3 = new Bitmap(width, height);
        Graphics g = Graphics.FromImage(img3);
        g.Clear(SystemColors.AppWorkspace);
        foreach (FileInfo file in files)
        {
            Image img = Image.FromFile(file.FullName);
            if (nIndex == 0)
            {
                g.DrawImage(img, new Point(0, 0));
                nIndex++;
                width = img.Width;
            }
            else
            {
                g.DrawImage(img, new Point(width, 0));
                width += img.Width;
            }
            img.Dispose();
        }
        g.Dispose();

        while (File.Exists(newFullUploadPath))
        {
            string tempFileName = string.Format("{0}({1})", fileNameOnly, count++);
            newFullUploadPath = Path.Combine(uploadPath, tempFileName + extension);
        }
        img3.Save(newFullUploadPath, System.Drawing.Imaging.ImageFormat.Jpeg);
        img3.Dispose();
        imageLocation.Image = Image.FromFile(newFullUploadPath);
        foreach (FileInfo file in files)
        {
            file.Delete();
        }
    }

    //Method to resize the images
    private static Image resizeImage(Image imgToResize, Size size)
    {
        return (Image)(new Bitmap(imgToResize, size));
    }

    private void SelectImages_Click(object sender, EventArgs e)
    {
        Stream myStream = null;
        OpenFileDialog openFileDialog1 = new OpenFileDialog();

        openFileDialog1.InitialDirectory = "c:\\";
        openFileDialog1.Filter = "png files (*.png)|*.png|All files (*.*)|*.*";
        openFileDialog1.FilterIndex = 2;
        openFileDialog1.RestoreDirectory = true;

        if (openFileDialog1.ShowDialog() == DialogResult.OK)
        {
                if ((myStream = openFileDialog1.OpenFile()) != null)
                {
                    int count = 1;
                    string fileNameOnly = Path.GetFileNameWithoutExtension(@"C:\Users\Elder Zollinger\Desktop\Images\Companion.jpg");
                    string extension = Path.GetExtension(@"C:\Users\Elder Zollinger\Desktop\Images\Companion.jpg");
                    string uploadPath = Path.GetDirectoryName(@"C:\Users\Elder Zollinger\Desktop\Images\Companion.jpg");
                    string newFullUploadPath = @"C:\Users\Elder Zollinger\Desktop\Images\Companion.jpg";
                    while (File.Exists(newFullUploadPath))
            {
                string tempFileName = string.Format("{0}({1})", fileNameOnly, count++);
                newFullUploadPath = Path.Combine(uploadPath, tempFileName + extension);
            }
                    System.IO.File.Copy(openFileDialog1.FileName, newFullUploadPath);
                }
            }
        }

    private void Clear_Click(object sender, EventArgs e)
    {
        imageLocation.Image = null;
        System.IO.DirectoryInfo downloadedMessageInfo = new DirectoryInfo(@"C:\Users\Elder Zollinger\Desktop\Images");

        foreach (FileInfo file in downloadedMessageInfo.GetFiles())
        {
            file.Delete();
        }
        foreach (DirectoryInfo dir in downloadedMessageInfo.GetDirectories())
        {
            dir.Delete(true);
        }
    }
    }
}

I suspect this is the problem:

Image img = Image.FromFile(file.FullName);

That opens the file - but you never dispose the same object, so the file will be open until the object is finalized. Image implements IDisposable, so you should use a using statement:

using (Image image = ...)
{
    ...
}

You should also dispose of the resized image, although at least that isn't holding on to a file handle.

Note that you've got the almost exactly the same block of code for whether there are more than two files or not. It would be cleaner to choose just the size conditionally:

Size size = fileCount > 2 ? new Size(66, 200) : new Size(100, 200);
using (Image original = Image.FromFile(file.FullName))
using (Image resized = ResizeImage(original, size))
{
     resized.Save(newFullUploadPath, ImageFormat.Jpeg);
}

Much cleaner, IMO.

See more on this question at Stackoverflow