Change ref element value with Array.ForEach?

I'm trying to use the Array.ForEach() extension method to loop through for a list of filtered elements from an array and then modify those values, unfortunately that doesn't seem to work I'm guessing because it doesn't actually modify the reference value of each element.

Is there any way to do this besides storing the results of the Array.ForEach() into a seperate array and then cloning that array to the original array? Also I know I could obviously do all of this without cloning if I use a for loop but if I could do it this way it would be cleaner and would be less code.

Here's the snippet:

Array.ForEach(Array.FindAll(starts, e => e < 0), e => e = 0);
Jon Skeet
people
quotationmark

ForEach simply isn't intended to do this - just like you wouldn't be able to do this with a foreach loop.

Personally I'd just use a for loop - it's easy to read and clear:

for (int i = 0; i < array.Length; i++)
{
    // Alternatively, use Math.Max to pull up any negative values to 0
    if (array[i] < 0)
    {
        array[i] = 0;
    }
}

It really is simple - anyone will be able to understand it.

Now you could write your own extension method instead. You could write one to replace all values which satisfy a predicate with a fixed value, or you could write one to replace all values entirely... but I don't think it's really worth it. As an example of the latter:

public static void ReplaceElements<T>(this T[] array,
                                      Func<T, T> replacementFunction)
{
    // TODO: Argument validation
    for (int i = 0; i < array.Length; i++)
    {
        array[i] = replacementFunction(array[i]);
    }
}

Then call it with:

starts.ReplaceElements(x => Math.Max(x, 0));

I'd personally still use the for loop though.

(You could potentially change the above very slightly to make it take IList<T> and use Count instead. That would still work with arrays, but also List<T> etc too.)

people

See more on this question at Stackoverflow