Excluding dates from period using Nodatime

I'm trying to workout the amount of time between two LocalDateTime values and exclude specific dates (in this example, it's bank holidays).

var bankHolidays = new[] { new LocalDate(2013, 12, 25), new LocalDate(2013, 12, 26) };
var localDateTime1 = new LocalDateTime(2013, 11, 18, 10, 30);
var localDateTime2 = new LocalDateTime(2013, 12, 29, 10, 15);

var differenceBetween = Period.Between(localDateTime1, localDateTime2, PeriodUnits.Days | PeriodUnits.HourMinuteSecond);

The differenceBetween value shows the number of days/hours/minutes/seconds between the two dates, as you would expect.

I could check every single day from the start date and see if the bankHolidays collection contains that date e.g.

var bankHolidays = new[] { new LocalDate(2013, 12, 25), new LocalDate(2013, 12, 26) };
var localDateTime1 = new LocalDateTime(2013, 11, 18, 10, 30);
var localDateTime2 = new LocalDateTime(2013, 12, 29, 10, 15);

var differenceBetween = Period.Between(localDateTime1, localDateTime2, PeriodUnits.Days | PeriodUnits.HourMinuteSecond);

var london = DateTimeZoneProviders.Tzdb["Europe/London"];

for (var i = 1; i < differenceBetween.Days; ++i)
{
    var x = localDateTime1.InZoneStrictly(london) + Duration.FromStandardDays(i);

    if (bankHolidays.Any(date => date == x.Date))
    {
        //subtract one day for the period.
    }
}

I feel like I'm missing some obvious and there should be an easier method, is there a simpler way to find a period between two dates whilst excluding certain dates?

I also need to include weekends in this exclusion too, the obvious way seems to be to check the day of the week for weekends whilst checking bank holidays, this just doesn't seem like the best/correct way of handling it though.

Jon Skeet
people
quotationmark

I feel like I'm missing some obvious and there should be an easier method, is there a simpler way to find a period between two dates whilst excluding certain dates?

Well, it's relatively easy to count the number of bank holidays included in a date-to-date range:

  • Sort all the bank holidays in chronological order
  • Use a binary search to find out where the start date would come in the collection
  • Use a binary search to find out where the end date would come in the collection
  • Subtract one index from another to find how many entries are within that range
  • Work out the whole period using Period.Between as you're already doing
  • Subtract the number of entries in the range from the total number of days in the range

The fiddly bit is taking into account that the start and/or end dates may be bank holidays. There's a lot of potential for off-by-one errors, but with a good set of unit tests it should be okay.

Alternatively, if you've got relatively few bank holidays, you can just use:

var period = Period.Between(start, end,
                            PeriodUnits.Days | PeriodUnits.HourMinuteSecond);
var holidayCount = holidays.Count(x => x >= start && x <= end);
period = period - Period.FromDays(holidayCount);

people

See more on this question at Stackoverflow